VCPKG port for onnxruntime and modernize cmake builds #7150
Comments
|
Nice! Also, I found finally they added versioning support. https://devblogs.microsoft.com/cppblog/take-control-of-your-vcpkg-dependencies-with-versioning-support/ That was really a blocking issue for us. If without it, Let's say if we put onnxruntime there, but later on protobuf gets a version that breaks onnxruntime build, what should we do? We can't publish a new release immediately just because Google protobuf did so. This was my main concern.
The biggest problem is how to handling ONNX. ONNX Runtime is not using a release version of ONNX. Can vcpkg accept such an ONNX package?
Sorry I don't know how to do that. Welcome to contribute! |
snnn
added
feature request
|
Hi, so for now |
|
Not yet. Welcome to contribute! |
You are not required or expected to immediately publish a new version in this case. The vcpkg maintainers ensure that all packages stay compatible, so as part of updating protobuf, they will ensure that all dependent packages continue to work (and include patches for them to make them compatible, if needed). |
…LLY_DISCONNECTED=ON` (#15323) ### Description Rework some external targets to ease building with `-DFETCHCONTENT_FULLY_DISCONNECTED=ON` This will allow package managers to more easily provide an onnxruntime package by reducing the amount of patching needed downstream at each version. ### Motivation and Context Availability of onnxruntime in some C++ package managers #7150 conan-io/conan-center-index#16699 microsoft/vcpkg#20548 My initial intent is to get this in conan but the PR would most likely be useful (though not tested) to vcpkg as well (and maybe others). I tried to get only a first batch of not too specific patches (i.e. not specific to conan). The first commit reworks `flatbuffers` and just extends what @snnn did in #13991 The second commit reworks `pytorch_cpuinfo` The third commit reworks `google_nsync`
…LLY_DISCONNECTED=ON` (microsoft#15323) ### Description Rework some external targets to ease building with `-DFETCHCONTENT_FULLY_DISCONNECTED=ON` This will allow package managers to more easily provide an onnxruntime package by reducing the amount of patching needed downstream at each version. ### Motivation and Context Availability of onnxruntime in some C++ package managers microsoft#7150 conan-io/conan-center-index#16699 microsoft/vcpkg#20548 My initial intent is to get this in conan but the PR would most likely be useful (though not tested) to vcpkg as well (and maybe others). I tried to get only a first batch of not too specific patches (i.e. not specific to conan). The first commit reworks `flatbuffers` and just extends what @snnn did in microsoft#13991 The second commit reworks `pytorch_cpuinfo` The third commit reworks `google_nsync`
**Description**: Adds support for cmake find_package. **Motivation and Context** As mentioned in issue #7150 onnxruntime doesn't have support for CMake find_package, this PR adds that and also adds the CMake package version file. Now anyone can link onnxruntime like this: ```cmake find_package(onnxruntime) add_executable(test Source.cpp) target_link_libraries(test PRIVATE onnxruntime::onnxruntime) ``` this also simplifies #3124
|
I tested luncliff's registry luncliff/vcpkg-registry , but encountered a similar problem with conan: conan-io/conan-center-index#17380 (comment) , luncliff/vcpkg-registry/issues/136#issuecomment-1851206111 |
Provider a vcpkg port for onnxruntime for easier builds and linking into external projects.
There's an initial effort made that can be used as a starting template for this
microsoft/vcpkg#14903
This port succeeds for x64-windows-static-md but none of the other standard triplets.
Overall the onnxruntime cmakelist.txt needs cleaning to support such a port in an efficient manner
The text was updated successfully, but these errors were encountered: