Tolerate cpuinfo init failure #10199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skottmckay
previously approved these changes
Jan 5, 2022
yufenglee
reviewed
Jan 11, 2022
| // Unfortunately we can not capture cpuinfo log!! | ||
| ORT_THROW("Failed to initialize CPU info."); | ||
| } | ||
| pytorch_cpuinfo_init_ = cpuinfo_initialize(); |
There was a problem hiding this comment.
It is not used when CPUIDINFO_ARCH_X86 is defined. move this to CPUIDINFO_ARCH_ARM section.
There was a problem hiding this comment.
hope is that cpuinfo should be used under more platforms , not just arm
yufenglee
approved these changes
Jan 11, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Tolerate pytorch cpuinfo library init failure.
Motivation and Context
#10038