-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds missing numpy type when looking for the ort correspondance #10943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natke
requested review from
hariharans29,
thiagocrepaldi,
baijumeswani and
yuslepukhin
and removed request for
yuslepukhin and
edgchen1
March 21, 2022 21:36
yuslepukhin
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lavanyax
pushed a commit
to intel/onnxruntime
that referenced
this pull request
Mar 29, 2022
chilo-ms
pushed a commit
that referenced
this pull request
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Use of NPY_LONG is ambiguous, it does not have the same meaning on all platforms (see https://numpy.org/doc/stable/reference/c-api/dtype.html). There were two functions implementing the mapping numpy type --> tensor type. This PR removes the wrong one.
Motivation and Context
Fixes issue #10853.