Fix profiling json format and enhance perf view #11046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangyaobit
approved these changes
Mar 29, 2022
|
How do we ensure we won't break the format next time? |
That's a sound concern, pls allow me to come up with a few test cases in a separate PR. |
pranavsharma
approved these changes
Mar 30, 2022
chausner
reviewed
Mar 31, 2022
| @@ -60,6 +60,7 @@ | |||
| preloader.visible(true); | |||
|
|
|||
| const fileList = event.target.files; | |||
| document.getElementById('filename').text = fileList[0].name; | |||
There was a problem hiding this comment.
Should use spaces instead of tabs.
chilo-ms
pushed a commit
that referenced
this pull request
Apr 15, 2022
Co-authored-by: Randy Shuai <rashuai@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the inputs of a node are composed of tensors and tensor sequence, profiling numbers in json format will have some invalid comma placed before ']', which result in parsing failure. To tackle the case, let variable "added_type_shapes" do the tracking dedicatedly.
Beyond the fix, reset perf view header whenever user opens a profiling file.