Scoped GIL release in run_with_iobinding #11248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1547,6 +1547,8 @@ including arg name, arg type (contains both type and shape).)pbdoc") | |||
| py::return_value_policy::reference_internal) | |||
| .def("run_with_iobinding", [](PyInferenceSession* sess, SessionIOBinding& io_binding, RunOptions* run_options = nullptr) -> void { | |||
| Status status; | |||
| // release GIL to allow multiple python threads to invoke Run() in parallel. | |||
There was a problem hiding this comment.
Should the comment still read Run() ?
pranavsharma
approved these changes
Apr 18, 2022
chilo-ms
pushed a commit
that referenced
this pull request
Apr 19, 2022
chilo-ms
added a commit
that referenced
this pull request
Apr 19, 2022
* Update tools/ci_build/upload_python_package_to_azure_storage.py to not use the azure blob storage python package (#11114) * Fix the rocm packaging pipeline package upload problem (#11174) In #11114 , I changed the script to use azcopy instead of azure blob storage's python APIs. However, it doesn't work for the AMD rocm pipeline, because: 1. The machines do not have azcopy installed 2. The machines are not in Azure, so they don't have Azure managed identity. So they still need to use SAS. Therefore in this PR I get the old python file back, but only use it in the AMD pipeline. * Scoped GIL release in run_with_iobinding (#11248) * [js/web] disable test_tan temorarily (#11048) * [js/web] fix output type mapping (#11049) Co-authored-by: Changming Sun <chasun@microsoft.com> Co-authored-by: Dmitri Smirnov <yuslepukhin@users.noreply.github.com> Co-authored-by: Yulong Wang <7679871+fs-eire@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Temporarily release GIL lock in pybind run_with_io_binding to allow concurrent runs.
Motivation and Context
Perf bug. Should be done like other runs.
Fixes: #11246