Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TVM EP][CI] Integrate TVM EP into ORT public CI on Windows #12161

Merged
merged 3 commits into from
Jul 18, 2022

Conversation

KJlaccHoeUM9l
Copy link
Contributor

Description
In our previous PR#11851 we added the ability to use TVM EP on Windows.
This PR integrates tests for checking TVM EP on Windows into public ORT CI.

Notes about LLVM
TVM EP requires LLVM. LLVM is already installed in Windows 2019 image we use to run the pipeline. However, this package is not suitable for building TVM EP. This is due to the fact that the packages of official LLVM releases for Windows (from their official GitHub) contain only runtime components, but for TVM we also need to have compilation libraries that are in LLVM-Dev.

This issue has been raised many times before:

To solve this problem on Windows, it is proposed to build LLVM yourself from the source code.

However, there is a faster way -- use Miniconda to install LLVM-Dev. And after installation, expand PATH environment variable with the following value: <miniconda_dir>\Library\bin.

@KJlaccHoeUM9l
Copy link
Contributor Author

Hello @xadupre!
Could you review the PR?
Also, an error occurred with Lint Python, but it is not related to this PR. The same error is observed in another PR: https://github.com/microsoft/onnxruntime/runs/7319325550?check_suite_focus=true

@KJlaccHoeUM9l
Copy link
Contributor Author

The problem seems to be on the pyright side: microsoft/pyright#3689.

@KJlaccHoeUM9l
Copy link
Contributor Author

Hello @xadupre!
The problem with pyright has been resolved: microsoft/pyright@879ab89
Now can we continue the review and run the remaining pipelines?

@xadupre
Copy link
Member

xadupre commented Jul 14, 2022

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows WebAssembly CI Pipeline, orttraining-amd-gpu-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, onnxruntime-python-checks-ci-pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 8 pipeline(s).

@xadupre
Copy link
Member

xadupre commented Jul 14, 2022

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, Linux TVM CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@xadupre
Copy link
Member

xadupre commented Jul 14, 2022

Sorry for the delay, I'm off today and the next day.

@KJlaccHoeUM9l
Copy link
Contributor Author

@xadupre, ok, come back when you're available.
All tests passed successfully. If you have no comments, can we merge the PR?

@ytaous ytaous requested a review from xadupre July 15, 2022 18:32
submodules: true
- uses: actions/setup-python@v3
with:
python-version: '3.8.x'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason you chose this version of python?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Ubuntu 20.04 this version comes out of the box. This version was the most tested (during development).
This version is also used in the Linux pipeline.
СС @snnn

@xadupre
Copy link
Member

xadupre commented Jul 18, 2022

Should I merge?

@KJlaccHoeUM9l
Copy link
Contributor Author

@xadupre,
yes, the PR is ready to merge.

@xadupre xadupre merged commit d31db1a into microsoft:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants