Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C# ] Improve string marshalling and reduce GC pressure #15545

Merged
merged 15 commits into from
Apr 20, 2023
Merged

[C# ] Improve string marshalling and reduce GC pressure #15545

merged 15 commits into from
Apr 20, 2023

Commits on Apr 14, 2023

  1. Removed PinnedHandle

    @yuslepukhin
    yuslepukhin committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    1575f22 View commit details
    Browse the repository at this point in the history

  2. Reduce the number of auxilary OrtMemoryAllocation instances

    @yuslepukhin
    yuslepukhin committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    8bdf230 View commit details
    Browse the repository at this point in the history

  3. Reuse pinned names

    @yuslepukhin
    yuslepukhin committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    dd15bec View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Reduce a number of auxillary objects created to reduce GC pressure. 

     Eliminate GCHandle type of memory pinning in most of the places.
 Improve string marshalling by allocating unmanaged memory that does not
 require pinning on our side (marshalling pinning is more efficient).
 Pin input/output names once for the life time of InferenceSession.

Co-Authored-By: @tannergooding
    @yuslepukhin
    yuslepukhin committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    9a0ae72 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Allocate input/output names in native heap to avoid pinning

    @yuslepukhin
    yuslepukhin committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    3220cf4 View commit details
    Browse the repository at this point in the history

  2. Fix a comment

    @yuslepukhin
    yuslepukhin committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    9f80b60 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into yuslepukhin/gc_reduction

    @yuslepukhin
    yuslepukhin committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    a3144e7 View commit details
    Browse the repository at this point in the history

  4. Introduce GetStringTensorElementBuffer 

    Add C++ API
    @yuslepukhin
    yuslepukhin committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    238c775 View commit details
    Browse the repository at this point in the history

  5. Fill out string tensor straight to the native buffer

    @yuslepukhin
    yuslepukhin committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    a5862d1 View commit details
    Browse the repository at this point in the history

  6. Address formatting failures

    @yuslepukhin
    yuslepukhin committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    7c02b0d View commit details
    Browse the repository at this point in the history

  7. Address lint failures

    @yuslepukhin
    yuslepukhin committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    4ee05bb View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Merge branch 'main' into yuslepukhin/gc_reduction

    @yuslepukhin
    yuslepukhin committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    3a50226 View commit details
    Browse the repository at this point in the history

  2. Address comments 

    Add ProviderOptionsUpdater
    @yuslepukhin
    yuslepukhin committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    38b45b5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into yuslepukhin/gc_reduction

    @yuslepukhin
    yuslepukhin committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    415df19 View commit details
    Browse the repository at this point in the history

  4. Rename the new API OrtApi struct member

    @yuslepukhin
    yuslepukhin committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    0782488 View commit details
    Browse the repository at this point in the history