Enabling c++20 on linux #17816
Enabling c++20 on linux #17816
Conversation
…ERTY LINK_FLAGS " -s ASSERTIONS=2 -s SAFE_HEAP=1 -s STACK_OVERFLOW_CHECK=2")"
…ING PROPERTY LINK_FLAGS " -s ASSERTIONS=2 -s SAFE_HEAP=1 -s STACK_OVERFLOW_CHECK=2")"" This reverts commit c72c40e.
|
We cannot do it for Linux CUDA build yet. Because the compiler we use is GCC 8, which is too low. |
|
Just out of curiosity. Why do you need C++20? Would it crash onnxruntime build in my old conda environment? |
|
For your second question, no. A new C++ standard consists of two things:
The first one doesn't have impact on compatibility. The second one has impacts on non-Windows/non-Linux systems like macOS/iOS. We can avoid the issue by not using the headers that are not supported by the target system. |
|
Wait this #20786 . The PR will update all GCCs to >=11. Now we still have GCC 8. |
|
The GCC version is updated. |
We can use the new C++ features to write better code, and it shouldn't impact our compatibility at runtime. The language features are listed in https://gcc.gnu.org/projects/cxx-status.html in "C++20 Language Features" section |
| @@ -326,11 +326,11 @@ class TreeAggregatorMin : public TreeAggregator<InputType, ThresholdType, Output | |||
| template <typename InputType, typename ThresholdType, typename OutputType> | |||
| class TreeAggregatorMax : public TreeAggregator<InputType, ThresholdType, OutputType> { | |||
| public: | |||
| TreeAggregatorMax<InputType, ThresholdType, OutputType>(size_t n_trees, | |||
There was a problem hiding this comment.
All other similar class like TreeAggregatorMin and TreeAggregatorSum does not include type qualifier.
|
depends on #21071 |
…nux_c++20 # Conflicts: # onnxruntime/contrib_ops/cuda/math/cufft_plan_cache.h # orttraining/orttraining/training_ops/cuda/nn/conv_shared.h # orttraining/orttraining/training_ops/rocm/nn/conv_grad.cc
| @@ -2748,7 +2748,7 @@ common::Status InferenceSession::RunAsync(const RunOptions* run_options, | |||
| if (!tp || concurrency::ThreadPool::DegreeOfParallelism(tp) < 2) { | |||
| return ORT_MAKE_STATUS(ONNXRUNTIME, INVALID_ARGUMENT, "intra op thread pool must have at least one thread for RunAsync"); | |||
| } | |||
| std::function<void()> run_fn = [=]() { | |||
| std::function<void()> run_fn = [=,this]() { | |||
There was a problem hiding this comment.
Use clang-format to format this code
|
This is also dependent on #21127 |
Description
Enabling c++20 on Linux
Currently blocking issue:
Motivation and Context
We want the latest and the greatest features from c++20.
depends on