Fix missing argument when calling _get_quantize_input_nodes #20245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you please add an unit test to cover it? |
I planned to. Building a unit test from the Olive one is not straightforword. |
|
done |
yufenglee
previously approved these changes
Apr 16, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
yufenglee
previously approved these changes
Apr 22, 2024
yufenglee
approved these changes
Apr 24, 2024
TedThemistokleous
pushed a commit
to TedThemistokleous/onnxruntime
that referenced
this pull request
May 7, 2024
…t#20245) ### Description The current code is calling one method with a missing argument. ### Motivation and Context It breaks Olive's unittests. --------- Co-authored-by: Xavier Dupré <xavier.dupre@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current code is calling one method with a missing argument.
Motivation and Context
It breaks Olive's unittests.