Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DML EP] Add MatMulNBits #20308

Merged
merged 11 commits into from
Apr 19, 2024
Merged

[DML EP] Add MatMulNBits #20308

merged 11 commits into from
Apr 19, 2024

Conversation

PatriceVignola
Copy link
Contributor

No description provided.

fdwr
fdwr previously approved these changes Apr 17, 2024
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few easy comments, else LGTM.

sumitsays
sumitsays previously approved these changes Apr 17, 2024
Copy link
Contributor

@sumitsays sumitsays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

fdwr
fdwr previously approved these changes Apr 17, 2024
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 One optional minor improvement.

@PatriceVignola
Copy link
Contributor Author

/azp run Windows GPU CI Pipeline

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PatriceVignola PatriceVignola dismissed stale reviews from fdwr and sumitsays via 5fe984c April 19, 2024 00:17
sumitsays
sumitsays previously approved these changes Apr 19, 2024
smk2007
smk2007 previously approved these changes Apr 19, 2024
Copy link
Member

@smk2007 smk2007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@PatriceVignola PatriceVignola merged commit 8fbb8a1 into main Apr 19, 2024
89 of 92 checks passed
@PatriceVignola PatriceVignola deleted the user/pavignol/add-matmul-n-bits branch April 19, 2024 22:05
TedThemistokleous pushed a commit to TedThemistokleous/onnxruntime that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants