-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of 'required reason' iOS API from protobuf #20529
Remove usage of 'required reason' iOS API from protobuf #20529
Conversation
xcframework from nuget package in 1.18 branch. randomly selected build artifact with xcframework to show the issue with existing code Output to show the multiple onnxruntime builds in the xcframework
Binaries reference
xcframework from PR
Binaries do not reference
Binaries do not reference
|
### Description <!-- Describe your changes. --> Using certain APIs is about to require a [privacy manifest](https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api) to be added to a package. Our version of protobuf uses `mach_absolute_time`. Patch as per protocolbuffers/protobuf#15662 to remove usage. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Usage of API will require a privacy manifest for an iOS app to be accepted as of 5/1/2024 #20519
) ### Description <!-- Describe your changes. --> Using certain APIs is about to require a [privacy manifest](https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api) to be added to a package. Our version of protobuf uses `mach_absolute_time`. Patch as per protocolbuffers/protobuf#15662 to remove usage. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Usage of API will require a privacy manifest for an iOS app to be accepted as of 5/1/2024 microsoft#20519
Description
Using certain APIs is about to require a privacy manifest to be added to a package.
Our version of protobuf uses
mach_absolute_time
. Patch as per protocolbuffers/protobuf#15662 to remove usage.Motivation and Context
Usage of API will require a privacy manifest for an iOS app to be accepted as of 5/1/2024
#20519