Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebNN EP] Support latest WebNN softmax op #20827

Merged
merged 2 commits into from
Jun 11, 2024
Merged

[WebNN EP] Support latest WebNN softmax op #20827

merged 2 commits into from
Jun 11, 2024

Conversation

Honry
Copy link
Contributor

@Honry Honry commented May 27, 2024

Latest WebNN softmax supports N-D input and axis parameter.

@Honry
[WebNN EP] Support latest WebNN softmax op
4db8f67 
Latest WebNN softmax supports N-D input and
axis parameter.
@Honry
Copy link
Contributor Author

Honry commented May 27, 2024 •
edited
Loading

This PR depends on Chromium's change at https://chromium-review.googlesource.com/c/chromium/src/+/5495877, please do not merge it until the CL is landed in Chromium.

@guschmue, @fs-eire, will we have ORT-Web 1.18.x release? This spec change is an API breaking, we will keep both APIs (old and new) in Chromium for a while, but we still hope to cherry pick it to the 1.18.x branch if it exists to unblock users from using ^1.18.0.

cc/ @fdwr, @huningxin, @miaobin

@guschmue guschmue added the ep:WebNN WebNN execution provider label May 28, 2024
@guschmue
Copy link
Contributor

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline

@guschmue
Copy link
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@guschmue
Copy link
Contributor

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 7 pipeline(s).

guschmue
guschmue previously approved these changes May 28, 2024
View reviewed changes
@Honry
Copy link
Contributor Author

Honry commented Jun 11, 2024

@guschmue, @fs-eire, will we have ORT-Web 1.18.x release? This spec change is an API breaking, we will keep both APIs (old and new) in Chromium for a while, but we still hope to cherry pick it to the 1.18.x branch if it exists to unblock users from using ^1.18.0.

@guschmue, @fs-eire, @fdwr, friendly ping.

@guschmue
Copy link
Contributor

there will be a 1.18 patch release but include we might be past cutoff - I need to check.

@guschmue
Copy link
Contributor

btw, this PR is stalled on missing docs update.

@Honry
Copy link
Contributor Author

Honry commented Jun 11, 2024 •
edited
Loading

there will be a 1.18 patch release but include we might be past cutoff - I need to check.

@guschmue, thanks! Chromium will not keep both APIs for long time (might be within 4 weeks), now only ort-web could help mitigate this kind of API breaking. Hopefully it's not too late.

cc/ @huningxin

btw, this PR is stalled on missing docs update.

I am going to fix it.

@guschmue
Copy link
Contributor

they are waiting for some other PR so we might be able to get this one in tomorrow after it is merged.

@Honry
Copy link
Contributor Author

Honry commented Jun 11, 2024

they are waiting for some other PR so we might be able to get this one in tomorrow after it is merged.

That's really cool, thank you so much!

I've fixed the doc conflict. PTAL.

@guschmue
Copy link
Contributor

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@guschmue
Copy link
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@guschmue
Copy link
Contributor

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@guschmue guschmue merged commit 043ef5c into microsoft:main Jun 11, 2024
70 checks passed
@sophies927 sophies927 added the triage:approved Approved for cherrypicks for release label Jun 11, 2024
fdwr
fdwr reviewed Jun 12, 2024
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Honry Thank you for updating this consistently with the browser.

@sophies927 sophies927 removed the triage:approved Approved for cherrypicks for release label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdwr fdwr fdwr left review comments

@guschmue guschmue guschmue approved these changes

Assignees
No one assigned
Labels
ep:WebNN WebNN execution provider release:1.18.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Honry @guschmue @fdwr @sophies927