Introduce a separate check and conditional for AVX512BW build #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracysh
reviewed
Oct 10, 2019
tracysh
reviewed
Oct 10, 2019
|
At this point, should the AVX512BW sources just be placed inside the AVX512F support block in the cmake file too? You can't have one without the other and it makes it clearer that AVX512F the intent and matches platform.cpp usage. #Pending |
tracysh
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Introduce as separate check and conditional compilation for AVX512BW instructions.
Motivation and Context
Some platforms support AVX512F but not AVX512BW