Zhijxu/fix softmax cudnn bf16 #21045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
orttraining/orttraining/test/python/orttraining_test_ortmodule_onnx_ops.py
Fixed
Show fixed
Hide fixed
zhijxu-MS
force-pushed
the
zhijxu/fix-softmax-cudnn-bf16
branch
from
a13f132
to
395ee82
Compare
which will call cudnn softmaxgrad internally
zhijxu-MS
force-pushed
the
zhijxu/fix-softmax-cudnn-bf16
branch
from
395ee82
to
8999a9c
Compare
wschin
reviewed
Jun 21, 2024
orttraining/orttraining/test/python/orttraining_test_ortmodule_onnx_ops.py
Outdated
Show resolved
Hide resolved
wschin
previously approved these changes
Jun 21, 2024
er3x3
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if seq >2048, ort will fallback to cudnn version, while when dtype is bf16, ort will throw exception, this PR trying to fix it.