Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCM] Exclude flash attention from hipify #21091

Merged
merged 1 commit into from
Jun 19, 2024
Merged

[ROCM] Exclude flash attention from hipify #21091

merged 1 commit into from
Jun 19, 2024

Conversation

tianleiwu
Copy link
Contributor

Description

Exclude flash attention sub-directory from hipify.

Motivation and Context

@tianleiwu tianleiwu requested a review from cloudhan June 19, 2024 04:07
cloudhan
cloudhan approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@cloudhan cloudhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so it is just "bert/flash_attention/*" is missing.

@tianleiwu tianleiwu merged commit 01279d8 into main Jun 19, 2024
96 of 99 checks passed
@tianleiwu tianleiwu deleted the tlwu/update_hipify_exclude branch June 19, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudhan cloudhan cloudhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tianleiwu @cloudhan