New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update onnx submodule to 1.7.0 release candidate #3405
Conversation
ONNX 1.7 release has been delayed a few weeks. We really want to get it done. I will appreciate if you can help ONNX community validate the release candidate. It would be good for all of us. When we start to taking the release to onnxruntime, if any major bug was found, we'll stop there and won't take it until the bug get fixed. In that case, the merging of training branch to master will also be delayed. I don't want to see it happan, that's why I'm spending time here. There is no conflict between your effort and mine, we're all towards to the same goal. I'm not hurried to merge this PR, because there are many failures needed be fixed, which takes time. If you want to help, I really appreciate it. Please submit your changes to the master branch, because most of the devs work on master, and many of them are waiting this change to get started working on opset 12 kernels. This is urgent. |
@snnn I understand this is urgent and you have to also understand I have been finding and fixing bugs w.r.t ONNX 1.7 release, please see onnx/onnx#2680 onnx/onnx#2667 and then #3392 that implements the kernel and re-enables disabled tests that were previously failing. |
Yes I know. Really thanks. Now the ONNX community want to know if the ONNX rel-1.7.0 branch is ready for release. So the release manager came to me and asked me helping me do a verification. He is waiting a response from me and I did find something in the last round of testing. If you also find something wrong in ONNX or If you're doing something that he should wait, please let us know. |
Cchasun@microsoft.com I need these changes, please, go ahead. This is blocking OpSet12 implementation In reply to: 607661043 [](ancestors = 607661043) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description:
Update onnx submodule to 1.7.0 release candidate
Motivation and Context
This is a chicken-egg problem. If we don't do this, we don't know if ONNX is ready to be released.