Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ONNX commit #5487

Merged
merged 12 commits into from Oct 21, 2020
Merged

Update ONNX commit #5487

merged 12 commits into from Oct 21, 2020

Conversation

askhade
Copy link
Contributor

@askhade askhade commented Oct 14, 2020 •
edited

Description: Updating the onnx commit to the latest master. Doing this to validate the onnx changes ahead of the 1.8 onnx release

Motivation and Context

  • Why is this change required? What problem does it solve?
  • If it fixes an open issue, please link to the issue here.

@askhade askhade requested a review from a team as a code owner October 14, 2020 18:03
@askhade askhade changed the title Update ONNX commit [WIP] Update ONNX commit Oct 15, 2020
@askhade askhade changed the title [WIP] Update ONNX commit Update ONNX commit Oct 19, 2020
@yuslepukhin
Copy link
Member

There were some changes in proto files although in comments, they clarify the standard with regards to sparse tensors. Please, sync those in.

@yuslepukhin
Copy link
Member

This commit should be split in two. One for ONNX and another for version upgrade. if we want to revert for some reason, it would be very messy.

yuslepukhin
yuslepukhin reviewed Oct 19, 2020
View reviewed changes
onnxruntime/test/providers/cpu/tensor/unsqueeze_op_test.cc
@@ -46,7 +46,8 @@ TEST(TensorOpTest, Unsqueeze_3) {
}

TEST(TensorOpTest, Unsqueeze_Duplicate) {
OpTester test("Unsqueeze", -1); // use latest opset for shape inference errors
// latest valid opset for this test is 12. Since opset 13 attribute axes was made an input.
OpTester test("Unsqueeze", 12);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can not bump it up. Ditto for everything else that requires implementation change.

Copy link
Contributor Author

@askhade askhade Oct 20, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These test changes are required because when opset is set to -1 test infra picks up latest available opset which is 13 now and tries to do schema and shape inf verification against latest opset.

yuslepukhin
yuslepukhin requested changes Oct 20, 2020
View reviewed changes
Copy link
Member

@yuslepukhin yuslepukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@askhade
Copy link
Contributor Author

askhade commented Oct 20, 2020

There were some changes in proto files although in comments, they clarify the standard with regards to sparse tensors. Please, sync those in.

ORT does not use the private proto file anymore. See this PR #4878
Since this PR ORT started using proto files from ONNX.

@askhade
Copy link
Contributor Author

askhade commented Oct 21, 2020

Bookkeeping : Nodejs mac pipeline failed during publish test results stage. The actual build and test onnxruntime stage was successful.

@askhade askhade merged commit df22611 into master Oct 21, 2020
@askhade askhade deleted the askhade/update_onnx branch October 21, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariharans29 hariharans29 hariharans29 left review comments

@yuslepukhin yuslepukhin yuslepukhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@askhade @yuslepukhin @hariharans29