Fix outputs of Sequences and Maps exposure. #5743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuslepukhin
requested review from
pranavsharma,
fs-eire,
hariharans29 and
RyanUnderhill
yuslepukhin
commented
Nov 10, 2020
snnn
previously approved these changes
Nov 10, 2020
|
Are existing tests already covering this ? #Resolved |
Remove transfer of ownership. Make sure RunWithBingind calls the right function.
|
Yes, I have just added a few more conditions In reply to: 724948049 [](ancestors = 724948049) |
yuslepukhin
commented
Nov 10, 2020
csharp/src/Microsoft.ML.OnnxRuntime/DisposableNamedOnnxValue.cs
Outdated
Show resolved
Hide resolved
yuslepukhin
commented
Nov 10, 2020
RyanUnderhill
previously approved these changes
Nov 10, 2020
hariharans29
previously approved these changes
Nov 10, 2020
yuslepukhin
dismissed stale reviews from hariharans29 and RyanUnderhill
via
de3dc11
RyanUnderhill
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Make sure that all OrtValues are properly disposed of. This includes map and sequence ortvalues as well as sequence elements that are currently leaked as the DisposableList is currently assigned to NamedOnnxValue member which does not dispose anything.
Motivation and Context