Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update onnx #8458

Merged
merged 22 commits into from Aug 5, 2021
Merged

Update onnx #8458

merged 22 commits into from Aug 5, 2021

Conversation

askhade
Copy link
Contributor

@askhade askhade commented Jul 22, 2021 •
edited

Description:
Update onnx to the latest in master (in preparation to support onnx 1.10)

  • Disable tests for unimplemented ops
  • Updates to function body initialization in accordance with the FunctionProto changes for IRv8

Motivation and Context

  • Why is this change required? What problem does it solve?
  • If it fixes an open issue, please link to the issue here.

@askhade askhade requested a review from a team as a code owner July 22, 2021 05:19
@askhade askhade requested a review from gramalingam July 22, 2021 05:19
@askhade askhade changed the title Update onnx [WIP] Update onnx Jul 22, 2021
@askhade askhade changed the title [WIP] Update onnx Update onnx Jul 26, 2021
@gramalingam
Copy link
Contributor

Is this supposed to handle model-local functions? I don't see a test for that. I don't also see where in the graph construction the resolution of a node's target to a model-local function happens. Is that future work?

gramalingam
gramalingam previously approved these changes Jul 28, 2021
View reviewed changes
snnn
snnn previously approved these changes Aug 3, 2021
View reviewed changes
@snnn snnn self-requested a review August 3, 2021 20:56
@snnn snnn dismissed their stale review August 3, 2021 20:56

There are some test failures in Nuget pipeline

@yan12125
Copy link
Contributor

yan12125 commented Aug 4, 2021

Maybe ONNX protobuf files also need updates? https://github.com/microsoft/onnxruntime/tree/master/onnxruntime/core/protobuf

@snnn
Copy link
Member

snnn commented Aug 4, 2021 •
edited

@yan12125 These files seems not used. Let me see if I can delete them. #8617

@yan12125 yan12125 mentioned this pull request Aug 5, 2021
Merged
@askhade askhade merged commit 96eb981 into master Aug 5, 2021
@askhade askhade deleted the update_onnx branch August 5, 2021 16:21
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this pull request May 9, 2024
@askhade
Update onnx (microsoft#8458)
7cff859 
* updates for picking pnnx commit

* add tests filter to c# tests

* plus test fixes

* fix versioning for contrib ops

* fix tests

* test filter for optional ops

* more versioning related updates

* fix test

* fix layernorm spec

* more updates

* update docs

* add more test filters

* more filters

* update binary size threshold

* update docs

* plus more fixes

* updates per review

* update to release commit

* add filters for optional type tests

* plus updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snnn snnn snnn approved these changes

@gramalingam gramalingam gramalingam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@askhade @gramalingam @yan12125 @snnn