Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transformations that impact graph outputs #1455

Closed
gramalingam opened this issue Apr 25, 2024 · 0 comments
Closed

Transformations that impact graph outputs #1455

gramalingam opened this issue Apr 25, 2024 · 0 comments
Assignees
@gramalingam
Labels
topic: rewriter

Comments

@gramalingam
Copy link
Collaborator

Currently, there is a problem when a rewrite-rule transforms how a graph-output is computed. Specifically, it ends up with a different name for the graph-output, and further there was no associated type for that value.

  • Ideally, we should not change graph output names
  • We need to ensure update types for graph outputs (via onnx inference, if needed)
@gramalingam gramalingam mentioned this issue Apr 25, 2024
Merged
@gramalingam gramalingam self-assigned this Apr 25, 2024
gramalingam added a commit that referenced this issue Apr 25, 2024
@gramalingam
Propagate relevant info from old values to new values (#1459)
9280fe7 
When we create new values to replace old ones, we lose some of the
information associated with the old values. Propagate this information.
(See #1455)
justinchuby pushed a commit that referenced this issue May 1, 2024
@gramalingam @justinchuby
Propagate relevant info from old values to new values (#1459)
59ce022 
When we create new values to replace old ones, we lose some of the
information associated with the old values. Propagate this information.
(See #1455)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gramalingam gramalingam

Labels
topic: rewriter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gramalingam @justinchuby