Turn on TORCHLIB_EXPERIMENTAL_PREFER_TRACING #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a BC breaking change. The flag `TORCHLIB_EXPERIMENTAL_PREFER_TRACING` allows most functions with control flows to be traced by default. This will eliminate some aten functions from the graph. We will
Test Results 29 files ±0 29 suites ±0 3h 6m 44s ⏱️ + 8m 17s For more details on these failures and errors, see this check. Results for commit ab73a54. ± Comparison against base commit c41ded5. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1304 +/- ##
==========================================
+ Coverage 77.51% 77.53% +0.01%
==========================================
Files 216 216
Lines 23337 23340 +3
Branches 4022 4023 +1
==========================================
+ Hits 18090 18096 +6
+ Misses 4473 4463 -10
- Partials 774 781 +7 ☔ View full report in Codecov by Sentry. |
titaiwangms
requested review from
titaiwangms
and removed request for
thiagocrepaldi and
BowenBao
titaiwangms
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a BC breaking change. The flag
TORCHLIB_EXPERIMENTAL_PREFER_TRACINGallows most functions with control flows to be traced by default. This will eliminate some aten functions from the graph. We will recreate these functions with #1218