support for subfunctions included in a subgraphs #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xadupre <xadupre@microsoft.com>
gramalingam
reviewed
Apr 11, 2022
gramalingam
reviewed
Apr 11, 2022
|
|
||
| @script(opset) | ||
| @script(CustomOpset('this', 1)) |
There was a problem hiding this comment.
Is there any significance to this change? If I am not mistaken, CustomOpset is mutable, with methods to add new functions to it. In principle, we could potentially update the opset object in script.
I think this does not matter right now, but I feel it may be useful to have examples share the same opset object in the long run.
There was a problem hiding this comment.
No significance except the converter failed. We should decide how to handle global variables, ignore them, or do something else. Ignore them is easier.
There was a problem hiding this comment.
I am surprised. Are you saying it fails with
opset = CustomOpset('this', 1)
@script(opset)but succeeds with
@script(CustomOpset('this', 1))
gramalingam
reviewed
Apr 12, 2022
Signed-off-by: xadupre <xadupre@microsoft.com>
Signed-off-by: xadupre <xadupre@microsoft.com>
gramalingam
reviewed
Jun 2, 2022
Signed-off-by: xadupre <xadupre@microsoft.com>
Signed-off-by: xadupre <xadupre@microsoft.com>
gramalingam
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xadupre xadupre@microsoft.com