-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the remaining unit tests for V2 and V3 deserializers #115
Comments
@PerthCharern Any reason why we are changing from using embedded resources to using file paths for test input files? My experience is that embedded files are much more reliable than depending on a file path that is relative to the working directory of the test runner. Now the CI scripts that run the tests have to worry about making sure the input files are in the right place. |
@darrelmiller Not a strong reason, but I found the syntax for embedded files a bit awkward. Instead of a path, it uses the period notation. I'm not sure if most people are familiar with using embedded files this way, but I might be completely wrong on this. I'm not sure what you meant by "Now the CI scripts that run the tests have to worry about making sure the input files are in the right place." Aren't this handled by the way we structure the files in the code base? |
I understand the concerns now. Let's track this embedded file problem in a separate issue. |
Continuation of #109.
#109 (through PR #113) already sets the structure of how the tests can be written for both versions of the deserializers. The remaining job is actually going ahead and write the tests for each and every object.
The text was updated successfully, but these errors were encountered: