Skip to content

Commit

Permalink
Modified for the invalid reference format of FROM BASE_IMAGE
Browse files Browse the repository at this point in the history
During the build images in the GitHub Actions, Following error had showed and failed to build the images.

```text
Step 1/18 : ARG INSTALLER_IMAGE="mcr.microsoft.com/cbl-mariner/base/core"
Step 2/18 : ARG INSTALLER_TAG="2.0"
Step 3/18 : ARG BASE_IMAGE="mcr.microsoft.com/cbl-mariner/distroless/base"
Step 4/18 : ARG BASE_TAG="2.0"
invalid reference format
Step 5/18 : FROM ${INSTALLER_IMAGE}:${INSTALLER_TAG} AS installer
```
  • Loading branch information
yoshioterada committed Oct 21, 2022
1 parent 36c9974 commit 06739f6
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions docker/distroless/Dockerfile.msopenjdk-11-jdk
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ ARG INSTALLER_TAG="2.0"
ARG BASE_IMAGE="mcr.microsoft.com/cbl-mariner/distroless/base"
ARG BASE_TAG="2.0"

FROM ${INSTALLER_IMAGE}:${INSTALLER_TAG} AS installer
FROM $INSTALLER_IMAGE:$INSTALLER_TAG AS installer

ARG JDK_URL="https://aka.ms/download-jdk/microsoft-jdk-11-linux-x64.tar.gz"

Expand Down Expand Up @@ -38,7 +38,7 @@ RUN rm -rf /staging/etc/dnf \
# Clean up JDK
RUN rm -rf /usr/jdk/man /usr/jdk/lib/src.zip

FROM ${BASE_IMAGE}:${BASE_TAG}
FROM $BASE_IMAGE:$BASE_TAG

LABEL "Author"="Microsoft"
LABEL "Support"="Microsoft OpenJDK Support <openjdk-support@microsoft.com>"
Expand Down
4 changes: 2 additions & 2 deletions docker/distroless/Dockerfile.msopenjdk-17-jdk
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ ARG INSTALLER_TAG="2.0"
ARG BASE_IMAGE="mcr.microsoft.com/cbl-mariner/distroless/base"
ARG BASE_TAG="2.0"

FROM ${INSTALLER_IMAGE}:${INSTALLER_TAG} AS installer
FROM $INSTALLER_IMAGE:$INSTALLER_TAG AS installer

ARG JDK_URL="https://aka.ms/download-jdk/microsoft-jdk-17-linux-x64.tar.gz"

Expand Down Expand Up @@ -38,7 +38,7 @@ RUN rm -rf /staging/etc/dnf \
# Clean up JDK
RUN rm -rf /usr/jdk/man /usr/jdk/lib/src.zip

FROM ${BASE_IMAGE}:${BASE_TAG}
FROM $BASE_IMAGE:$BASE_TAG

LABEL "Author"="Microsoft"
LABEL "Support"="Microsoft OpenJDK Support <openjdk-support@microsoft.com>"
Expand Down
4 changes: 2 additions & 2 deletions docker/distroless/Dockerfile.temurin-8-jdk
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ ARG INSTALLER_TAG="2.0"
ARG BASE_IMAGE="mcr.microsoft.com/cbl-mariner/distroless/base"
ARG BASE_TAG="2.0"

FROM ${INSTALLER_IMAGE}:${INSTALLER_TAG} AS installer
FROM $INSTALLER_IMAGE:$INSTALLER_TAG AS installer

ARG PKGS="ca-certificates tzdata freetype"
ARG JDK_URL="https://api.adoptium.net/v3/binary/latest/8/ga/linux/x64/jdk/hotspot/normal/eclipse?project=jdk"
Expand All @@ -27,7 +27,7 @@ RUN mkdir /staging \
&& cp /etc/passwd /staging/etc/passwd \
&& cp /etc/group /staging/etc/group

FROM ${BASE_IMAGE}:${BASE_TAG}
FROM $BASE_IMAGE:$BASE_TAG

LABEL "Author"="Microsoft"
LABEL "Support"="Microsoft OpenJDK Support <openjdk-support@microsoft.com>"
Expand Down
2 changes: 1 addition & 1 deletion docker/mariner-cm1/Dockerfile.msopenjdk-11-jdk
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ARG IMAGE="mcr.microsoft.com/cbl-mariner/base/core"
ARG TAG="1.0"
FROM ${IMAGE}:${TAG}
FROM $IMAGE:$TAG

LABEL "Author"="Microsoft"
LABEL "Support"="Microsoft OpenJDK Support <openjdk-support@microsoft.com>"
Expand Down
2 changes: 1 addition & 1 deletion docker/mariner-cm1/Dockerfile.msopenjdk-17-jdk
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ARG IMAGE="mcr.microsoft.com/cbl-mariner/base/core"
ARG TAG="1.0"
FROM ${IMAGE}:${TAG}
FROM $IMAGE:$TAG

LABEL "Author"="Microsoft"
LABEL "Support"="Microsoft OpenJDK Support <openjdk-support@microsoft.com>"
Expand Down
2 changes: 1 addition & 1 deletion docker/mariner/Dockerfile.msopenjdk-11-jdk
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ARG IMAGE="mcr.microsoft.com/cbl-mariner/base/core"
ARG TAG="2.0"
FROM ${IMAGE}:${TAG}
FROM $IMAGE:$TAG

LABEL "Author"="Microsoft"
LABEL "Support"="Microsoft OpenJDK Support <openjdk-support@microsoft.com>"
Expand Down
2 changes: 1 addition & 1 deletion docker/mariner/Dockerfile.msopenjdk-17-jdk
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ARG IMAGE="mcr.microsoft.com/cbl-mariner/base/core"
ARG TAG="2.0"
FROM ${IMAGE}:${TAG}
FROM $IMAGE:$TAG

LABEL "Author"="Microsoft"
LABEL "Support"="Microsoft OpenJDK Support <openjdk-support@microsoft.com>"
Expand Down
2 changes: 1 addition & 1 deletion docker/mariner/Dockerfile.temurin-8-jdk
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ARG IMAGE="mcr.microsoft.com/cbl-mariner/base/core"
ARG TAG="2.0"
FROM ${IMAGE}:${TAG}
FROM $IMAGE:$TAG

LABEL "Author"="Microsoft"
LABEL "Support"="Microsoft OpenJDK Support <openjdk-support@microsoft.com>"
Expand Down

0 comments on commit 06739f6

Please sign in to comment.