This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Implement proxies for Azure exporters #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 92.71% 92.73% +0.01%
==========================================
Files 21 21
Lines 1139 1142 +3
Branches 140 141 +1
==========================================
+ Hits 1056 1059 +3
Misses 55 55
Partials 28 28
Continue to review full report at Codecov.
|
hectorhdzg
reviewed
Jun 24, 2020
hectorhdzg
reviewed
Jun 24, 2020
| @@ -49,6 +51,7 @@ def __init__( | |||
| self, | |||
| connection_string: str = None, | |||
| instrumentation_key: str = None, | |||
| proxies: typing.Dict[str, str] = None, | |||
There was a problem hiding this comment.
Maybe setting the default as {} instead of None to avoid check afterwards
There was a problem hiding this comment.
Mutable defaults are a common pitfall in Python. https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments
hectorhdzg
approved these changes
Jun 24, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to specify proxies that the request to Azure Monitor backend will pass through.
Users will pass in a string representing a dict format.
See requests for more details.