This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Implement max size logic for local storage #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
storage_max_sizeconfiguration in exporters did not do anything.Implements this logic in
storageto stop storing files in local storage once max size has been reached (may have some spillage if the envelope is actually larger than the remaining size).Runs size check everytime a
putis called in storage, instead of saving the size of the folder. Keeping state will require us to handle concurrency issues and also introduces complications when adding/deleting.See dot net and java implementations of this logic.