Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Remove label sets + add is_remote to spancontext #75

Merged
merged 6 commits into from Apr 6, 2020

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Apr 3, 2020

@lzchen lzchen requested a review from hectorhdzg as a code owner April 3, 2020 02:14
@codecov-io
Copy link

codecov-io commented Apr 3, 2020

Codecov Report

Merging #75 into master will decrease coverage by 0.09%.
The diff coverage is 97.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   98.67%   98.57%   -0.10%     
==========================================
  Files          14       14              
  Lines         753      774      +21     
  Branches       97      102       +5     
==========================================
+ Hits          743      763      +20     
  Misses          8        8              
- Partials        2        3       +1     
Impacted Files Coverage Δ
azure_monitor/src/azure_monitor/options.py 100.00% <ø> (ø)
azure_monitor/src/azure_monitor/storage.py 99.31% <94.73%> (-0.69%) ⬇️
...nitor/src/azure_monitor/export/metrics/__init__.py 100.00% <100.00%> (ø)
.../src/azure_monitor/sdk/auto_collection/__init__.py 100.00% <100.00%> (ø)
..._monitor/sdk/auto_collection/dependency_metrics.py 100.00% <100.00%> (ø)
...monitor/sdk/auto_collection/performance_metrics.py 100.00% <100.00%> (ø)
...ure_monitor/sdk/auto_collection/request_metrics.py 100.00% <100.00%> (ø)
azure_monitor/src/azure_monitor/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 017f470...d218c19. Read the comment docs.

@lzchen
Copy link
Contributor Author

lzchen commented Apr 3, 2020

@lzchen lzchen changed the title Remove label sets Remove label sets + add is_remote to spancontext Apr 3, 2020
Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzchen lzchen merged commit 8cc6b08 into microsoft:master Apr 6, 2020
@lzchen lzchen deleted the remove branch April 6, 2020 03:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove labelsets from metrics
3 participants