Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

fix serializable bug in metrics exporter #92

Merged
merged 1 commit into from
May 21, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,12 @@ def export(
self, metric_records: Sequence[MetricRecord]
) -> MetricsExportResult:
envelopes = list(map(self._metric_to_envelope, metric_records))
envelopes = self._apply_telemetry_processors(envelopes)
envelopes = list(
map(
lambda x: x.to_dict(),
self._apply_telemetry_processors(envelopes),
)
)
try:
result = self._transmit(envelopes)
if result == ExportResult.FAILED_RETRYABLE:
Expand Down
6 changes: 3 additions & 3 deletions azure_monitor/tests/metrics/test_metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def test_export(self, mte, transmit):
CounterAggregator(), self._test_labels, self._test_metric
)
exporter = self._exporter
mte.return_value = []
mte.return_value = Envelope()
transmit.return_value = ExportResult.SUCCESS
result = exporter.export([record])
self.assertEqual(result, MetricsExportResult.SUCCESS)
Expand All @@ -124,7 +124,7 @@ def test_export_failed_retryable(self, mte, transmit):
)
exporter = self._exporter
transmit.return_value = ExportResult.FAILED_RETRYABLE
mte.return_value = []
mte.return_value = Envelope()
storage_mock = mock.Mock()
exporter.storage.put = storage_mock
result = exporter.export([record])
Expand All @@ -143,7 +143,7 @@ def test_export_exception(self, mte, transmit, logger_mock):
CounterAggregator(), self._test_labels, self._test_metric
)
exporter = self._exporter
mte.return_value = []
mte.return_value = Envelope()
transmit.side_effect = throw(Exception)
result = exporter.export([record])
self.assertEqual(result, MetricsExportResult.FAILURE)
Expand Down