Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge r2m PR#326 - Add support for mandatory installation of OMI #342

Merged
merged 1 commit into from Jun 4, 2018

Conversation

eltoncarr
Copy link
Contributor

What does this PR do? Please provide some context

Add support for installing the latest version of OMI package.

Where should the reviewer start?

A bug was found related to the crontab entry recently, and a hot fix, omi-1.4.1-1, was released. The fix is also available in most recent release, omi-1.4.2-1. This bug occurred on systems that don’t have Kerberos installed, and caused an error email to be generated every minute.

How can this be manually tested? (brief repro steps and corpnet-URL with change)

The updated utilities.sh library file and how it is integrated with the installation process via the install-tools function.

What are the relevant TFS items? (list id numbers)

source utilities.sh
install-omi

Definition of done:

  • Title of the pull request is clear and informative
  • Add pull request hyperlink to relevant TFS items
  • For large or complex change: schedule an in-person review session
  • This change has appropriate test coverage
  • Get at least two approvals

Reminders DURING merge

  1. If you're merging from a short-term (feature) branch into a long-term branch (like dev, release, or master) then "Squash and merge" to keep our history clean.
  2. If merging from two longterm branches (like cherry picks from upstream, dev to release, etc) then "Create merge commit" to preserve individual commits.

@eltoncarr eltoncarr merged commit 6760124 into oxa/master.fic Jun 4, 2018
@eltoncarr
Copy link
Contributor Author

Thanks

@eltoncarr eltoncarr deleted the oxa/master.fic-omifix branch June 4, 2018 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants