This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
Add protocol submission plugin #2461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add protocol submission plugin: * import protocol yaml file * view/edit protocol yaml file with monaco editor Known issues: * monaco editor cannot be bundled by webpack for plugin * editor worker has the wrong base url * language highlight and some editor styles do not work in plugin
|
|
6 tasks
Update webpack config file.
Update protocol form.
2 similar comments
This comment has been minimized.
This comment has been minimized.
Add webpack public path.
Support clone from job list.
sunqinzheng
suggested changes
Apr 1, 2019
Update according to comments.
Use immutable update to clone state.
Add `componentDidMount`.
sunqinzheng
reviewed
Apr 2, 2019
Update `componentDidMount`.
Add bootstrap css.
Pick monaco-hack style and fix line number margin.
Use react-bootstrap.
Add loading spinner.
Fix tslint issue.
Use css modules in bootstrap styles.
Remove string literal in styles.
Add parameters textfield.
Fix tslint errors.
Gerhut
suggested changes
Apr 10, 2019
Gerhut
suggested changes
Apr 10, 2019
abuccts
force-pushed
the
xiongyf/protocol-plugin
branch
from
88be99f
to
e24126b
Compare
Add one feature in monaco plugin to reduce bundle size, due to a bug in https://github.com/Microsoft/monaco-editor-webpack-plugin/blob/v1.7.0/index.js#L38.
Gerhut
approved these changes
Apr 12, 2019
sunqinzheng
approved these changes
Apr 12, 2019
abuccts
added a commit
that referenced
this pull request
Apr 15, 2019
- [Docs] Finalize protocol spec: merged pai-proto branch. - [Docs] Add new yaml files that follow new protocol: #2292. - [Rest Server] Protocol yaml parsing, validation and rendering: #2274. - [Rest Server] Convert protocol to framework launcher description file: #2291. - [Rest Server] Refactor and update rest API v2: #2329. - [Webportal] Add submission protocol plugin: #2461.
sunqinzheng
pushed a commit
that referenced
this pull request
Apr 16, 2019
- [Docs] Finalize protocol spec: merged pai-proto branch. - [Docs] Add new yaml files that follow new protocol: #2292. - [Rest Server] Protocol yaml parsing, validation and rendering: #2274. - [Rest Server] Convert protocol to framework launcher description file: #2291. - [Rest Server] Refactor and update rest API v2: #2329. - [Webportal] Add submission protocol plugin: #2461.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add protocol submission plugin:
Known issues: