This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
[Web Portal] New user management UI. #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuccts
reviewed
May 8, 2019
mslichao
force-pushed
the
lchao/newUserManagementUI1
branch
from
b0acf3b
to
e44a2ab
Compare
sunqinzheng
suggested changes
May 9, 2019
sunqinzheng
reviewed
May 10, 2019
sunqinzheng
reviewed
May 10, 2019
sunqinzheng
reviewed
May 10, 2019
| <Modal | ||
| isOpen={showEditInfo.isOpen} | ||
| styles={{main: [t.mw8, t.w90]}}> | ||
| <div dangerouslySetInnerHTML={{__html: showEditInfo.innerHtml}} /> |
There was a problem hiding this comment.
Could you refactor the ejs into a react component?
sunqinzheng
reviewed
May 10, 2019
sunqinzheng
approved these changes
May 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2494 in #2078
This PR only change the root page of user management. Will modify other pages when designer gave the new design.
below is the screenshot: