This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
[Rest Server] Check default runtime before starting Docker #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check default runtime before starting Docker, fix #2739. If nvidia-docker is installed and nvidia runtime is enabled by default, start nvidia-docker and isolate GPU through NVIDIA_VISIBLE_DEVICES provided by nvidia runtime.
Binyang2014
approved these changes
May 14, 2019
| @@ -142,7 +142,7 @@ const generateYarnContainerScript = (frameworkName, userName, config, frameworkD | |||
| azRDMA: azureEnv.azRDMA === 'true' ? true : false, | |||
| reqAzRDMA: false, | |||
| inspectPidFormat: '{{.State.Pid}}', | |||
| inspectOOMKilledFormat: '{{.State.OOMKilled}}', | |||
| infoDefaultRuntimeFormat: '{{json .DefaultRuntime}}', | |||
There was a problem hiding this comment.
Seems this field is static and we can put it into the shell script.
There was a problem hiding this comment.
the {{ ... }} will be replaced by mustache in shell script template, so we have to put it here as a workaround.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check default runtime before starting Docker, fix #2739.
If nvidia-docker is installed and nvidia runtime is enabled by default, start nvidia-docker and isolate GPU through
NVIDIA_VISIBLE_DEVICESprovided by nvidia runtime.