Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

[Rest Server] Add job config v1 to v2 converter #2756

Merged
merged 3 commits into from
May 15, 2019

Conversation

abuccts
Copy link
Member

@abuccts abuccts commented May 14, 2019

Add job config v1 to v2 converter.

Add job config v1 to v2 converter.
@coveralls
Copy link

coveralls commented May 14, 2019

Coverage Status

Coverage increased (+0.3%) to 53.368% when pulling 37f9341 on xiongyf/protocol-converter into a32a51c on master.

Move converter to utils directory.
Copy link
Contributor

@Binyang2014 Binyang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to write UT for this?

Add unit tests for v1 to v2 converter.
@abuccts abuccts requested a review from Binyang2014 May 15, 2019 03:40
@abuccts abuccts merged commit e61e659 into master May 15, 2019
@abuccts abuccts deleted the xiongyf/protocol-converter branch May 15, 2019 07:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants