This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
add gpu temperature detection #2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuccts
reviewed
May 14, 2019
| return self.gpu_util == o.gpu_util and \ | ||
| self.gpu_mem_util == o.gpu_mem_util and \ | ||
| self.pids == o.pids and \ | ||
| self.ecc_errors == o.ecc_errors and \ | ||
| self.minor == o.minor and \ | ||
| self.uuid == o.uuid | ||
| self.uuid == o.uuid and \ | ||
| self.temperature == o.temperature | ||
|
|
||
|
|
||
| def parse_smi_xml_result(smi): |
There was a problem hiding this comment.
It's better to use NVIDIA System Management Interface (NVML), or its Python bindings to get GPU status, which is backwards compatible, while nvidia-smi's output is not guaranteed to be backwards compatible according to its docs.
There was a problem hiding this comment.
Ok, will try to investigate and use them in future PR.
3 similar comments
mzmssg
approved these changes
May 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required by DLWS, may also be useful to pai.