This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
[Rest Server] Update restart policy to avoid stuck pending pods #3856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update restart policy to avoid stuck pending pods #3760
yqwang-ms
approved these changes
Nov 15, 2019
Binyang2014
reviewed
Nov 15, 2019
| @@ -319,7 +319,7 @@ const generateTaskRole = (taskRole, labels, config) => { | |||
| }, | |||
| spec: { | |||
| privileged: false, | |||
| restartPolicy: 'Never', | |||
| restartPolicy: gangAllocation === 'true' ? 'Never' : 'OnFailure', | |||
There was a problem hiding this comment.
Add comments for this? We should revert this change after we update k8s to 16.2 or above.
Add comments
Binyang2014
approved these changes
Nov 18, 2019
|
User may not want to forever retry on failure. Could alert auto delete the pod if detected such issue? @Binyang2014 |
Maybe we can use alert-manager webhook to achieve this web-hook. Create another service receive such alert and do some actions. For better experience, admin can config this webhook's reaction when alert is received. For now, if we want to auto delete the pod. I think we should find a way to let admin know what will happen, and admin can turn off such feature if it causes other issues. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update restart policy to avoid stuck pending pods #3760.