Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

[Webportal] Add filter, search box and export csv file in task detail list #5175

Merged

Conversation

yiyione
Copy link
Contributor

@yiyione yiyione commented Dec 14, 2020

Add Search box, filter, and export csv feature to task detail list page.

exportcsv,search,filter

@yiyione yiyione requested a review from debuggy December 14, 2020 23:26
@yiyione yiyione mentioned this pull request Dec 14, 2020
52 tasks
@coveralls
Copy link

coveralls commented Dec 14, 2020

Coverage Status

Coverage remained the same at 33.999% when pulling 3c2f318 on yiyi/webportal/add_sort_filter_search_in_task_detail_list into 0be199f on master.

@yiyione yiyione merged commit 93396f4 into master Dec 16, 2020
@yiyione yiyione deleted the yiyi/webportal/add_sort_filter_search_in_task_detail_list branch December 16, 2020 07:32
@yiyione
Copy link
Contributor Author

yiyione commented Dec 16, 2020

Test cases:

  1. keyword search, in job detail page:
    a. input task state to search
    b. input exit type to search
    c. input exit code to search
    d. input ip address to search
    e. input container id to search
  2. filter, in job detail page:
    a. filter by task state
    b. filter by exit type
    c. filter by exit code
    d. filter by node name
  3. export csv file:
    click export csv file, and open it, check if the file is correct.

@suiguoxin
Copy link
Member

suiguoxin commented Dec 29, 2020

Issues:
filter:
- filter by exit code doesn't work: {int bed}/job-detail.html?username=zhiyuhe&jobName=large_retry

Questions:
export csv file:
- why export by taskRole*jobAttempt ?
- no job level / job attempt level info
- info & logs are not contained in the csv
- title running start time/ running duration are not clear

@debuggy debuggy mentioned this pull request Jan 4, 2021
14 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants