Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont pull usage data for customers without a reseller relationship #32

Merged
merged 2 commits into from
Feb 20, 2017

Conversation

ssugar
Copy link
Contributor

@ssugar ssugar commented Feb 5, 2017

Stops the CSPUsage API from throwing an exception with the following message:
Reseller CAID XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX does not have a reseller relationship with customer CAID XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX.

@msftclas
Copy link

msftclas commented Feb 5, 2017

Hi @ssugar, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@ssugar
Copy link
Contributor Author

ssugar commented Feb 6, 2017

Updated the fix to use the CustomerPartnerRelationship model for comparison instead of a string.

@snpdev snpdev mentioned this pull request Feb 20, 2017
Copy link
Contributor

@UtkarshVIT UtkarshVIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding partner-customer relationship check before pulling data

@UtkarshVIT UtkarshVIT merged commit 0461755 into microsoft:master Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants