docs

microsoft · May 23, 2024 · 5153769 · 5153769
1 parent fee63f9
commit 5153769
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/src/TraceEvent/TraceLog.cs b/src/TraceEvent/TraceLog.cs
@@ -224,17 +224,29 @@ public static TraceLogEventSource CreateFromEventPipeSession(EventPipeSession se
             return traceLog.realTimeSource;
         }
 
+        /// <summary>
+        /// EventPipe real-time tracelog session configuration, used to populate the method and module information.
+        /// </summary>
         public class EventPipeRundownConfiguration
         {
             internal readonly DiagnosticsClient m_client;
 
             private EventPipeRundownConfiguration(DiagnosticsClient client) { m_client = client; }
 
+            /// <summary>
+            /// No rundown will be requested, thus it may be impossible to symbolicate events. This is OK, if you don't
+            /// require method/module info the captured events.
+            /// </summary>
             public static EventPipeRundownConfiguration None()
             {
                 return new EventPipeRundownConfiguration(null);
             }
 
+            /// <summary>
+            /// If the rundown is enabled and a DiagnosticsClient is given, TraceLog.CreateFromEventPipeSession will
+            /// create an additional short-lived diagnostics session to load all module/method information up to that
+            /// point.
+            /// </summary>
             public static EventPipeRundownConfiguration Enable(DiagnosticsClient client)
             {
                 return new EventPipeRundownConfiguration(client);
@@ -318,12 +330,6 @@ private unsafe void OnAllEventPipeEventsRealTime(TraceEvent data)
                 rawEventSourceToConvert.currentID = (EventIndex)eventCount;
             }
 
-            // Skip samples from the idle thread.
-            if (data.ProcessID == 0 && data is SampledProfileTraceData)
-            {
-                return;
-            }
-
             var extendedDataCount = data.eventRecord->ExtendedDataCount;
             if (extendedDataCount != 0)
             {