Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for override formatter formatException #140

Merged

Conversation

aminalaee
Copy link
Contributor

Closes #103

@codecov-commenter
Copy link

Codecov Report

Merging #140 (bbc1fe9) into main (783acf1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #140   +/-   ##
=======================================
  Coverage   89.05%   89.05%           
=======================================
  Files          11       11           
  Lines        2119     2119           
=======================================
  Hits         1887     1887           
  Misses        232      232           
Impacted Files Coverage Δ
src/picologging/handlers.py 94.55% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aminalaee aminalaee force-pushed the add-tests-for-format-exception-override branch from bbc1fe9 to c9f5739 Compare May 22, 2023 10:34
@aminalaee aminalaee marked this pull request as ready for review May 22, 2023 10:37
Copy link
Contributor

@tonybaloney tonybaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@tonybaloney tonybaloney merged commit b4369cf into microsoft:main Sep 25, 2023
1 check passed
@aminalaee aminalaee deleted the add-tests-for-format-exception-override branch September 25, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overriding formatter.formatException is not permitted
3 participants