feat: Implementation for connecting remote playwright browser #1488
Conversation
|
|
| /// </summary> | ||
| /// <param name="wsEndpoint">Call wsEndpoint</param> | ||
| /// <param name="options">Call options</param> | ||
| Task<IBrowser> ConnectAsync(string wsEndpoint, BrowserTypeConnectOptions options = default); |
There was a problem hiding this comment.
Do we have an upstream PR for this?
There was a problem hiding this comment.
Hey, nope this is not yet implemented for visibility have raised PR. Currently, it is not working as expected I have been stuck while retrieving the Browser object. It would be great if you guide me through this we can get this connect feature fully implemented as per as requirement. I happy to contribute on this :)
There was a problem hiding this comment.
@kblok Can you please guide me through this or do you any upcoming PRs with such feature implemented?
There was a problem hiding this comment.
All the code inside the generated directory is auto-generated using generateDotnetApi.js.
So, if you want to generate this connect method, you should change class-browsertype.md first.
Once approved, all the interfaces and options will be auto-generated for you :)
|
Closing this PR tracking here : #1602 |
No description provided.