chore: migrate to server side connect #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
feature/connect
branch
from
4789b52
to
240389c
Compare
mxschmitt
commented
Dec 29, 2021
mxschmitt
force-pushed
the
feature/connect
branch
from
240389c
to
1b1445b
Compare
kblok
reviewed
Dec 30, 2021
mxschmitt
force-pushed
the
feature/connect
branch
2 times, most recently
from
5b08ef0
to
460b013
Compare
mxschmitt
force-pushed
the
feature/connect
branch
2 times, most recently
from
24a54a8
to
11d3b8c
Compare
mxschmitt
commented
Jan 6, 2022
mxschmitt
commented
Jan 6, 2022
mxschmitt
commented
Jan 6, 2022
mxschmitt
commented
Jan 6, 2022
mxschmitt
force-pushed
the
feature/connect
branch
2 times, most recently
from
c9a0533
to
dab8db0
Compare
pavelfeldman
approved these changes
Jan 13, 2022
| } | ||
| browser = playwright.PreLaunchedBrowser; | ||
| browser.ShouldCloseConnectionOnClose = true; | ||
| browser.Disconnected += (_, _) => ClosePipe(); |
There was a problem hiding this comment.
I would hope that the line above takes care of this.
| } | ||
| var task = CreateBrowserTask(); | ||
| var timeout = options?.Timeout != null ? (int)options.Timeout : 30_000; |
There was a problem hiding this comment.
We don't technically need it, can be improved in a separate PR.
| @@ -603,6 +598,10 @@ private Task WaitForURLAsync(string urlString, Regex urlRegex, Func<string, bool | |||
| private Waiter SetupNavigationWaiter(string @event, float? timeout) | |||
| { | |||
| var waiter = new Waiter((this.Page as Page)!.Channel, @event); | |||
| if (this.Page.IsClosed) | |||
There was a problem hiding this comment.
We should refactor it (and in upstream) to only rely on the connection. I.e. don't hide the waitForEventInfo rejection.
mxschmitt
force-pushed
the
feature/connect
branch
from
dab8db0
to
ff0faa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #986