feat: Upgrade to Java 11 and module system #1165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make Playwright finally easy to use in modular projects
|
@microsoft-github-policy-service agree |
I'm pretty confident in saying that the submitted PR won't be merged, no problem, I'll use my fork
yury-s
reviewed
Jan 11, 2023
| @@ -37,9 +37,9 @@ | |||
| </build> | |||
| <dependencies> | |||
| <dependency> | |||
| <groupId>com.microsoft.playwright</groupId> | |||
| <groupId>io.github.palexdev.playwright</groupId> | |||
There was a problem hiding this comment.
Revert this and similar changes in other pom.xml files
There was a problem hiding this comment.
Oh I'm very sorry for this, I didn't know the commit would be automatically added to the PR
Since I needed the library in one of my modular projects yesterday I decided to publish artifacts on my maven repo
I'll update the PR in the morning
| <artifactId>driver</artifactId> | ||
| <version>${project.version}</version> | ||
| <version>1.30.0</version> |
| @@ -42,7 +42,7 @@ | |||
| </modules> | |||
|
|
|||
| <properties> | |||
| <compiler.version>1.8</compiler.version> | |||
| <compiler.version>11</compiler.version> | |||
There was a problem hiding this comment.
Is it compatible with Java 8 or will it break the clients whose source version is set to 1.8?
There was a problem hiding this comment.
No it won't work with Java 8 anymore
The module system has been introduced by Java 9, the closest LTS release is JDK11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Playwright finally easy to use in modular projects
Oh, this will also require the update of workflows to use at least JDK11