fix: manually pipe messages from child process sdtout/stderr #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No, despite the name getInputStream() returns child process' stdout. I was
confused by that too.
…On Wed, May 5, 2021 at 11:53 PM Dan Manastireanu ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In driver-bundle/src/test/java/com/microsoft/playwright/TestInstall.java
<#426 (comment)>
:
> Process p = pb.start();
+ StreamRedirectThread stdoutThread = new StreamRedirectThread(p.getInputStream(), System.out);
Shouldn't this be p.getOutpuStream(), not input stream?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#426 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACKYKJMQCKLSG4WZYIVYGXLTMI4HHANCNFSM44F5SVLQ>
.
--
Thanks,
Yury
|
This was referenced May 6, 2021
yury-s
added a commit
to yury-s/playwright-java
that referenced
this pull request
May 12, 2021
…icrosoft#426)" This reverts commit 0fa416b.
yury-s
added a commit
that referenced
this pull request
May 12, 2021
yury-s
added a commit
to yury-s/playwright-java
that referenced
this pull request
May 12, 2021
…icrosoft#426)" (microsoft#440) This reverts commit 0fa416b.
yury-s
added a commit
that referenced
this pull request
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spawn a new dedicated thread to pump stderr/stdout from the driver child process to playwright process to mitigate possible problems with inheriting streams in Java Enterprise described in [BUG] Playwright cannot download the browsers automatically #418
Close driver connection when reading from child process fails, this should help with [Question] what is the reason when the "Browser.close" message was sent, but never received a response message back? #347