Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve video naming #217

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix: improve video naming #217

merged 1 commit into from
Apr 15, 2024

Conversation

mxschmitt
Copy link
Member

Before they were named with a random name.webm, now its either video.webm or video-i.webm.

@mxschmitt mxschmitt mentioned this pull request Apr 15, 2024
Merged
@mxschmitt mxschmitt changed the title feat: improve video naming fix: improve video naming Apr 15, 2024
yury-s
yury-s approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming we always use separate dir per test output

@mxschmitt mxschmitt merged commit 3cec62e into main Apr 15, 2024
14 of 17 checks passed
@mxschmitt mxschmitt deleted the feature/rename-videos branch April 15, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mxschmitt @yury-s