Correct the launch_browser fixture behaviour when --browser-channel f… #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! What was exactly not working? Could you please file first an issue report with a repro? |
|
Sure, will do right now |
…ehaviour-with-browser-channel' into correct-launch-browser-fixture-behaviour-with-browser-channel
kumaraditya303
suggested changes
Oct 1, 2021
| @@ -170,6 +170,12 @@ def launch_browser( | |||
| browser_type_launch_args: Dict, | |||
| browser_type: BrowserType, | |||
| ) -> Callable[..., Browser]: | |||
| if ( | |||
| browser_type.name != "chromium" | |||
| and browser_type_launch_args.get("channel") == "chrome" | |||
There was a problem hiding this comment.
Suggested change
| and browser_type_launch_args.get("channel") == "chrome" |
| browser_type.name != "chromium" | ||
| and browser_type_launch_args.get("channel") == "chrome" | ||
| ): | ||
| del browser_type_launch_args["channel"] |
There was a problem hiding this comment.
Suggested change
| del browser_type_launch_args["channel"] | |
| browser_type_launch_args.pop("channel",None) |
|
Closing since it seems stale and we recommend to run pytest multiple times with the correct parameters instead of running it a single time and a few parameters won't get passed over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lag is used