Skip to content

Commit

Permalink
chore(roll): roll to v1.30 (#1734)
Browse files Browse the repository at this point in the history
  • Loading branch information
mxschmitt committed Jan 23, 2023
1 parent db99c36 commit 9a4587a
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 10 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Playwright is a Python library to automate [Chromium](https://www.chromium.org/H

| | Linux | macOS | Windows |
| :--- | :---: | :---: | :---: |
| Chromium <!-- GEN:chromium-version -->109.0.5414.74<!-- GEN:stop --> ||||
| Chromium <!-- GEN:chromium-version -->110.0.5481.38<!-- GEN:stop --> ||||
| WebKit <!-- GEN:webkit-version -->16.4<!-- GEN:stop --> ||||
| Firefox <!-- GEN:firefox-version -->108.0.2<!-- GEN:stop --> ||||

Expand Down
5 changes: 2 additions & 3 deletions scripts/expected_api_mismatch.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,12 @@ Parameter type mismatch in Accessibility.snapshot(return=): documented as Union[

# One vs two arguments in the callback, Python explicitly unions.
Parameter type mismatch in BrowserContext.route(handler=): documented as Callable[[Route, Request], Union[Any, Any]], code has Union[Callable[[Route, Request], Any], Callable[[Route], Any]]
Parameter type mismatch in BrowserContext.unroute(handler=): documented as Union[Callable[[Route, Request], Any], None], code has Union[Callable[[Route, Request], Any], Callable[[Route], Any], None]
Parameter type mismatch in BrowserContext.unroute(handler=): documented as Union[Callable[[Route, Request], Union[Any, Any]], None], code has Union[Callable[[Route, Request], Any], Callable[[Route], Any], None]
Parameter type mismatch in Page.route(handler=): documented as Callable[[Route, Request], Union[Any, Any]], code has Union[Callable[[Route, Request], Any], Callable[[Route], Any]]
Parameter type mismatch in Page.unroute(handler=): documented as Union[Callable[[Route, Request], Any], None], code has Union[Callable[[Route, Request], Any], Callable[[Route], Any], None]
Parameter type mismatch in Page.unroute(handler=): documented as Union[Callable[[Route, Request], Union[Any, Any]], None], code has Union[Callable[[Route, Request], Any], Callable[[Route], Any], None]

# Temporary Fix
Method not implemented: Error.name
Method not implemented: Error.stack
Method not implemented: Error.message
Method not implemented: PlaywrightAssertions.expect
Method not implemented: Locator.viewport_ratio
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
InWheel = None
from wheel.bdist_wheel import bdist_wheel as BDistWheelCommand

driver_version = "1.30.0-alpha-jan-16-2023"
driver_version = "1.30.0-beta-1674276599000"


def extractall(zip: zipfile.ZipFile, path: str) -> None:
Expand Down
4 changes: 2 additions & 2 deletions tests/async/test_fetch_global.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,9 @@ async def test_should_support_global_user_agent_option(
async def test_should_support_global_timeout_option(
playwright: Playwright, server: Server
):
request = await playwright.request.new_context(timeout=1)
request = await playwright.request.new_context(timeout=100)
server.set_route("/empty.html", lambda req: None)
with pytest.raises(Error, match="Request timed out after 1ms"):
with pytest.raises(Error, match="Request timed out after 100ms"):
await request.get(server.EMPTY_PAGE)


Expand Down
2 changes: 1 addition & 1 deletion tests/async/test_page.py
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,7 @@ async def test_fill_should_throw_on_unsupported_inputs(page, server):
)
with pytest.raises(Error) as exc_info:
await page.fill("input", "")
assert f'input of type "{type}" cannot be filled' in exc_info.value.message
assert f'Input of type "{type}" cannot be filled' in exc_info.value.message


async def test_fill_should_fill_different_input_types(page, server):
Expand Down
4 changes: 2 additions & 2 deletions tests/sync/test_fetch_global.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ def test_should_support_global_user_agent_option(
def test_should_support_global_timeout_option(
playwright: Playwright, server: Server
) -> None:
request = playwright.request.new_context(timeout=1)
request = playwright.request.new_context(timeout=100)
server.set_route("/empty.html", lambda req: None)
with pytest.raises(Error, match="Request timed out after 1ms"):
with pytest.raises(Error, match="Request timed out after 100ms"):
request.get(server.EMPTY_PAGE)


Expand Down

0 comments on commit 9a4587a

Please sign in to comment.