chore: lint examples and fix to_{have,contain}_text with lists (#1675)

microsoft · Dec 2, 2022 · eaf3f15 · eaf3f15
1 parent d87e105
commit eaf3f15
Show file tree

Hide file tree

Showing 21 changed files with 7,389 additions and 4,128 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -23,7 +23,6 @@ repos:
     hooks:
       - id: mypy
         additional_dependencies: [types-pyOpenSSL==22.1.0.1]
-        exclude: examples/
   - repo: https://github.com/pycqa/flake8
     rev: 5.0.4
     hooks:

diff --git a/README.md b/README.md
@@ -4,7 +4,7 @@ Playwright is a Python library to automate [Chromium](https://www.chromium.org/H
 
 |          | Linux | macOS | Windows |
 |   :---   | :---: | :---: | :---:   |
-| Chromium <!-- GEN:chromium-version -->108.0.5359.29<!-- GEN:stop --> | ✅ | ✅ | ✅ |
+| Chromium <!-- GEN:chromium-version -->108.0.5359.48<!-- GEN:stop --> | ✅ | ✅ | ✅ |
 | WebKit <!-- GEN:webkit-version -->16.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
 | Firefox <!-- GEN:firefox-version -->106.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |
 

diff --git a/examples/todomvc/tests/__init__.py → examples/todomvc/mvctests/__init__.py b/examples/todomvc/tests/__init__.py → examples/todomvc/mvctests/__init__.py
diff --git a/...omvc/tests/test_clear_completed_button.py → ...c/mvctests/test_clear_completed_button.py b/...omvc/tests/test_clear_completed_button.py → ...c/mvctests/test_clear_completed_button.py
diff --git a/examples/todomvc/tests/test_counter.py → examples/todomvc/mvctests/test_counter.py b/examples/todomvc/tests/test_counter.py → examples/todomvc/mvctests/test_counter.py
diff --git a/examples/todomvc/tests/test_editing.py → examples/todomvc/mvctests/test_editing.py b/examples/todomvc/tests/test_editing.py → examples/todomvc/mvctests/test_editing.py
diff --git a/examples/todomvc/tests/test_item.py → examples/todomvc/mvctests/test_item.py b/examples/todomvc/tests/test_item.py → examples/todomvc/mvctests/test_item.py
diff --git a/...domvc/tests/test_mark_all_as_completed.py → ...vc/mvctests/test_mark_all_as_completed.py b/...domvc/tests/test_mark_all_as_completed.py → ...vc/mvctests/test_mark_all_as_completed.py
diff --git a/examples/todomvc/tests/test_new_todo.py → examples/todomvc/mvctests/test_new_todo.py b/examples/todomvc/tests/test_new_todo.py → examples/todomvc/mvctests/test_new_todo.py
diff --git a/examples/todomvc/tests/test_persistence.py → ...ples/todomvc/mvctests/test_persistence.py b/examples/todomvc/tests/test_persistence.py → ...ples/todomvc/mvctests/test_persistence.py
diff --git a/examples/todomvc/tests/test_routing.py → examples/todomvc/mvctests/test_routing.py b/examples/todomvc/tests/test_routing.py → examples/todomvc/mvctests/test_routing.py
diff --git a/examples/todomvc/tests/utils.py → examples/todomvc/mvctests/utils.py b/examples/todomvc/tests/utils.py → examples/todomvc/mvctests/utils.py
@@ -23,4 +23,6 @@ def assert_number_of_todos_in_local_storage(page: Page, expected: int) -> None:
 
 
 def check_todos_in_local_storage(page: Page, title: str) -> None:
-    title in page.evaluate("JSON.parse(localStorage['react-todos']).map(i => i.title)")
+    assert title in page.evaluate(
+        "JSON.parse(localStorage['react-todos']).map(i => i.title)"
+    )
diff --git a/playwright/_impl/_assertions.py b/playwright/_impl/_assertions.py
@@ -120,7 +120,13 @@ def _not(self) -> "LocatorAssertions":
 
     async def to_contain_text(
         self,
-        expected: Union[List[Union[Pattern[str], str]], Pattern[str], str],
+        expected: Union[
+            List[str],
+            List[Pattern[str]],
+            List[Union[Pattern[str], str]],
+            Pattern[str],
+            str,
+        ],
         use_inner_text: bool = None,
         timeout: float = None,
         ignore_case: bool = None,
@@ -163,7 +169,13 @@ async def to_contain_text(
 
     async def not_to_contain_text(
         self,
-        expected: Union[List[Union[Pattern[str], str]], Pattern[str], str],
+        expected: Union[
+            List[str],
+            List[Pattern[str]],
+            List[Union[Pattern[str], str]],
+            Pattern[str],
+            str,
+        ],
         use_inner_text: bool = None,
         timeout: float = None,
         ignore_case: bool = None,
@@ -199,7 +211,13 @@ async def not_to_have_attribute(
 
     async def to_have_class(
         self,
-        expected: Union[List[Union[Pattern[str], str]], Pattern[str], str],
+        expected: Union[
+            List[str],
+            List[Pattern[str]],
+            List[Union[Pattern[str], str]],
+            Pattern[str],
+            str,
+        ],
         timeout: float = None,
     ) -> None:
         __tracebackhide__ = True
@@ -222,7 +240,13 @@ async def to_have_class(
 
     async def not_to_have_class(
         self,
-        expected: Union[List[Union[Pattern[str], str]], Pattern[str], str],
+        expected: Union[
+            List[str],
+            List[Pattern[str]],
+            List[Union[Pattern[str], str]],
+            Pattern[str],
+            str,
+        ],
         timeout: float = None,
     ) -> None:
         __tracebackhide__ = True
@@ -346,7 +370,7 @@ async def not_to_have_value(
 
     async def to_have_values(
         self,
-        values: List[Union[Pattern[str], str]],
+        values: Union[List[str], List[Pattern[str]], List[Union[Pattern[str], str]]],
         timeout: float = None,
     ) -> None:
         __tracebackhide__ = True
@@ -360,15 +384,21 @@ async def to_have_values(
 
     async def not_to_have_values(
         self,
-        values: List[Union[Pattern[str], str]],
+        values: Union[List[str], List[Pattern[str]], List[Union[Pattern[str], str]]],
         timeout: float = None,
     ) -> None:
         __tracebackhide__ = True
         await self._not.to_have_values(values, timeout)
 
     async def to_have_text(
         self,
-        expected: Union[List[Union[Pattern[str], str]], Pattern[str], str],
+        expected: Union[
+            List[str],
+            List[Pattern[str]],
+            List[Union[Pattern[str], str]],
+            Pattern[str],
+            str,
+        ],
         use_inner_text: bool = None,
         timeout: float = None,
         ignore_case: bool = None,
@@ -407,7 +437,13 @@ async def to_have_text(
 
     async def not_to_have_text(
         self,
-        expected: Union[List[Union[Pattern[str], str]], Pattern[str], str],
+        expected: Union[
+            List[str],
+            List[Pattern[str]],
+            List[Union[Pattern[str], str]],
+            Pattern[str],
+            str,
+        ],
         use_inner_text: bool = None,
         timeout: float = None,
         ignore_case: bool = None,