Install browsers upon pip install, not the first launch

[pavelfeldman]

That improves user experience

[mxschmitt]

I made some research. There is no good native way of having a postinstall script. It could be implemented like that with egg_info which is super hacky, not sure how it performs: https://stackoverflow.com/a/45021666/6512681

[pavelfeldman]

I actually made it work as described here: https://stackoverflow.com/questions/20288711/post-install-script-with-python-setuptools

But pip is suppressing the I/O, so there are no progress bars visible, which defeats the purpose of this UX improvement.

[mxschmitt]

I thought about the following design when we compare it with other tools like .

• They have a command line interface which they use to download files. In their case language models spacy download en_core_web_sm
• It can be exposed via setup.py like package.json>bin in the Node.js world
• If no browsers are persistent, I would download the used browser on launch() instead of all browsers

So the user can decide, either use the CLI to download the browser or the used browser get's downloaded on launch.

[pavelfeldman]

That's probably it, we'll have the plagwright install for now

[ColdHeat]

Thanks for working on playwright, it's much needed for automated tests!

I personally think that I would rather have browsers installed during the pip install step even if it didn't have progress bars.

I looked around for a way to automatically install browsers on first test run perhaps and it looks like you would have to modify sys.argv to use the existing main() install.

playwright-python/playwright/main.py

Lines 123 to 133 in fc5485c

	def main() -> None:
	if "install" not in sys.argv:
	print('Run "python -m playwright install" to complete installation')
	return
	package_path = get_file_dirname()
	driver_name = compute_driver_name()
	driver_executable = package_path / "drivers" / driver_name
	print("Installing the browsers...")
	subprocess.check_call(f"{driver_executable} install", shell=True)
	print("Playwright is now ready for use")

Could the install function perhaps be extracted this into a separate function that can be called without modifying sys.argv?