New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: roll driver to 1.3.0-next.1596843106133, handle paths on the client side #163
Conversation
Pull Request Test Coverage Report for Build 199934606Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, again in sync with upstream.
@@ -57,7 +57,7 @@ async def test_context_cookies_should_work(server, launch_persistent): | |||
"expires": -1, | |||
"httpOnly": False, | |||
"secure": False, | |||
"sameSite": "None", | |||
"sameSite": "Lax" if is_firefox else "None", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Andrey says that Firefox has switched the defaults.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"There is currently no timeline to ship this feature to the release channel of Firefox.". Let's make sure to fix it upstream. Filing a bug
We might need to update client then to ensure proper 🍪 roundtrip. |
Should we postpone this until upstream is fixed? |
Pavel was fine with it (via Slack). |
No description provided.