fix: fulfill with json #1700
Merged
fix: fulfill with json #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwoll
commented
Dec 29, 2022
| @@ -16,6 +16,7 @@ | |||
| import base64 | |||
| import inspect | |||
| import json | |||
| import json as json_utils | |||
There was a problem hiding this comment.
This definitely works, but perhaps there is a more idiomatic and future proof approach. The original issue was missed since the parameter is/was typed as Any so json.dumps was valid from the typechecker's perspective, but in reality was wrong since json shadowed and referred to the method's parameter.
pavelfeldman
approved these changes
Dec 29, 2022
rwoll
added a commit
to rwoll/playwright-python
that referenced
this pull request
Dec 29, 2022
Resolves microsoft#1693. Relates microsoft/playwright#19184 (original upstream change). Relates microsoft#1684 (original Python rolling introducing the feature to the port).
rwoll
added a commit
that referenced
this pull request
Dec 29, 2022
fix: fulfill with json (#1700) Resolves #1693. Relates microsoft/playwright#19184 (original upstream change). Relates #1684 (original Python rolling introducing the feature to the port).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1693.
Relates microsoft/playwright#19184 (original upstream change).
Relates #1684 (original Python rolling introducing the feature to the port).